Fix branch max on calls during ACT#329
Open
2over12 wants to merge 1 commit intoGillianPlatform:masterfrom
Open
Fix branch max on calls during ACT#3292over12 wants to merge 1 commit intoGillianPlatform:masterfrom
2over12 wants to merge 1 commit intoGillianPlatform:masterfrom
Conversation
Contributor
|
And thanks again :D Will hopefully review soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from in progress LLVM support
When executing with a spec, regardless of how many specs are matched successfully etc, the call is considered branching which causes unexpected requirements on call factors. This causes unexpected unrolling requirements on examples like: https://github.com/trail-of-forks/Gillian/blob/9db721dc9cb70c3914dd28d1ef383f6b99c98a63/Gillian-LLVM/examples/wpst/mem_test.gil#L15 where 3 is required to handle all of the calls.
The intended fix here is to just add the number of matched specs exceeding 1 call